opensearch-project / oui

OpenSearch UI Framework
Apache License 2.0
35 stars 69 forks source link

Fix version selector for parity with previous version #1205

Open BSFishy opened 8 months ago

BSFishy commented 8 months ago

Description

The current version selector navigates to <url>/<version> instead of <url>/<version>/. The trailing / is necessary to navigate to the correct version. Currently, if you try navigating to a different version on https://oui.opensearch.org/1.4/, it won't change the version.

Additionally, I made a change to the way the response promise is handled to properly handle case where there is an error with the fetch.

I think a change was made to the CDK to fix this as well, but I wanted to keep parity with the previous version of the version selector

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BSFishy commented 8 months ago

Does this need a changelog entry?

ashwin-pc commented 8 months ago

No this does not need a changelog entry :)