opensearch-project / oui

OpenSearch UI Framework
Apache License 2.0
31 stars 65 forks source link

Add new components in sidecar that can be reused #1257

Open raintygao opened 3 months ago

raintygao commented 3 months ago

Is your feature request related to a problem? Please describe. There is a sidecar implementation in OSD, it includes some components that can be reused. We could support some appropriate components and replace raw implementation with them in OSD once supported.

Sidecar contains some resizable button style already defined in OUI, but resizableButton in OUI is not exported and not easy for plugin to import to use, so we'd better research how to redesign this part. We have something to be discussed, including which directions are supported, only left and right, or can takeover from the bottom? Is it just a push effect or can it also be covered? Exporting just the button or a resizableFlyout seems more appropriate? These require us to spend time thinking and then let the designer decide.

Describe the solution you'd like We should do a research on what components in the sidecar should be supported in OUI, including what properties, how to design, etc.

Additional context Sidecar RFC: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5620 Sidecar OSD PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5920

raintygao commented 2 months ago

image After some research, i think we could separate a new component named resizableButton from resizableContainer, and user could implement custom resizable features through this component.

So there will be no UX changes, only involves some component props updates. Hi @AMoo-Miki do you know the process of OUI update? Could I implement directly or needs to involve somebody to review?

AMoo-Miki commented 1 month ago

i think we could separate a new component Could I implement directly

Of course. Please do and raise a PR.

dblock commented 2 weeks ago

Catch All Triage - 1 2 3 4 5