opensearch-project / performance-analyzer-commons

Apache License 2.0
4 stars 18 forks source link

Refactoring Service/Stat Metrics #14

Closed khushbr closed 1 year ago

khushbr commented 1 year ago

Is your feature request related to a problem? Please provide an existing Issue # , or describe. https://github.com/opensearch-project/performance-analyzer-commons/issues/8

Describe the solution you are proposing

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tjofil commented 1 year ago

In commons/stats/eval/impl/vals, subpackages sound generic and don't have much meaning, do we keep them, rename them or flatten them back ?

khushbr commented 1 year ago

In commons/stats/eval/impl/vals, subpackages sound generic and don't have much meaning, do we keep them, rename them or flatten them back ?

We can later revisit and flatten this out. I wanted to keep this consistent with directory structure in RCA package to ensure we don't miss any of the files. The README is also arranged as per the structure, we can update both later.