Collectors migration from PA-RCA

opensearch-project / performance-analyzer-commons

Apache License 2.0

4 stars 18 forks source link

Collectors migration from PA-RCA #17

Closed Tjofil closed 1 year ago

Tjofil commented 1 year ago

Check List

[ ] New functionality includes testing.
- [ ] All tests pass
[ ] New functionality has been documented.
- [ ] New functionality has javadoc added
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

khushbr commented 1 year ago

One high level comment which we should address later: The library assumes lot of primitives, which we should interface out to the consumers. Specifically the contents of config/opensearch-performance-analyzer/performance-analyzer.properties, should be part of the RCA/PA, which can be made config arguments.