Closed kartva closed 10 months ago
Let's add the output of the unit test in the PR description as well.
@ansjcy
Let's add the output of the unit test in the PR description as well.
Running ./gradlew test --tests ThreadSchedTests
gives me:
org.opensearch.performanceanalyzer.commons.os.ThreadSchedTests > testMetrics STARTED
org.opensearch.performanceanalyzer.commons.os.ThreadSchedTests > testMetrics PASSED
Is this what you meant by that? Or is it pasting the assertions that the unit test makes about the class being tested?
Alternatives to implementing equals
on ThreadSched.SchedMetrics
:
Out of which implementing equality seemed the simplest.
Turns out the test class does not meet the requirements to access a private member of ThreadSched.SchedMetrics
, so using reflection seems infeasible.
Is your feature request related to a problem? Please provide an existing Issue # , or describe. Add tests for
os/ThreadSched.java
.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.