opensearch-project / performance-analyzer-commons

Apache License 2.0
4 stars 18 forks source link

add completionCount constants for co-ordinator and shard level tasks #53

Closed kaushalmahi12 closed 9 months ago

kaushalmahi12 commented 10 months ago

Adding completionCount metrics constants. This was previously not part of /stats/search_backpressure API as the change got merged post 2.11 release. We will need this metric to find correct cancellation percentage with respect to total completed tasks at shard and co-ordinator level.

Github issue: https://github.com/opensearch-project/performance-analyzer/issues/587

Is your feature request related to a problem? Please provide an existing Issue # , or describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ansjcy commented 10 months ago

LGTM.

deshsidd commented 9 months ago

LGTM apart from the minor nit