opensearch-project / performance-analyzer-commons

Apache License 2.0
4 stars 18 forks source link

feat: mute collectors based on exception count #56

Open kartva opened 10 months ago

kartva commented 10 months ago

Is your feature request related to a problem? Please provide an existing Issue # , or describe. As discussed at https://github.com/opensearch-project/performance-analyzer/issues/549

Describe the solution you are proposing We use the exception counts maintained by StatsCollector to dynamically mute collectors based on the number of exceptions they throw in the last minute of sampling.

Additional context Currently in the proof of concept stage. If this is successful, further avenues of investigation may be:

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kartva commented 9 months ago

What sort of configuration setting do you think would be appropriate for exceptionMuteLimit? Would this have a default value (like 5) or be off by default? I imagine having it off by default will be sensible.

kartva commented 9 months ago

summary of changes so far: