Open peterzhuamazon opened 1 year ago
We have a new approach established here. Please see this sample workflow file from Alerting for example: https://github.com/opensearch-project/alerting/blob/main/.github/workflows/multi-node-test-workflow.yml
Thanks.
This might not be able to onboard as this repo requires docker
and docker-compose
to complete the gradle task. This would result in a dind situation, also there is no docker
and docker-compose
in our build image.
Thanks.
We need PA team to help us understand the gradle build process so we can onboard docker images later.
Thanks.
Hi All,
This is coming from the campaign here:
Overview
We would like your CI check (specifically plugin build) in GitHub Repo to run on top of the Build Docker Images from production distribution pipeline.
This is to ensure every plugin repo will use the exact docker images we used in Jenkins build, to check their PRs and run tests before merging the code, so that issues can be detected earlier, and environment can be identical across teams.
Solutions
The Build Team has created a simple script to dynamically retrieve the current docker image name/tag, so everyone can easily pull the images for their CI checks.
We have a trial run of the above with k-NN team. The script retrieves the docker image dynamically, save output, and use it as the docker image to pull for the upcoming run:
Note that GitHub Actions only support LINUX docker container at the time of this writing, so we will add Windows containers later on as well as macOS.
Implementation Notes
We would like you to review above PR and implement similar changes. Note on line
33
of the above k-NN PR,-u
and-p
parameters needs to assign values accordingly.OpenSearch Plugin:
OpenSearch-Dashboards Plugin:
Note that in the above k-NN PR, despite it being OpenSearch plugin, it still uses
rockylinux8
, as we initially plan to upgrade to rockylinux. We have since revert back tocentos7
to support older versions of systems running k-NN lib. As a result, all OpenSearch plugins still usescentos7
for the time being, and all OpenSearch-Dashboards plugins can go torockylinux8
.Completion Date
The above should be implemented by
Nov. 1, 2023 (2023-11-01)
by Plugin Owners to their repository. And backport the changes to2.x
branch after merging inmain
branch.Contacts
Please contact @peterzhuamazon for any questions on this campaign.
cc: @bbarani
Thanks.