search

opensearch-project / performance-analyzer-rca

The Performance Analyzer RCA is a framework that builds on the Performance Analyzer engine to support root cause analysis (RCA) of performance and reliability problems for OpenSearch instances.
https://opensearch.org/docs/latest/monitoring-plugins/pa/rca/index/
Apache License 2.0
29 stars 56 forks source link

[1.3] Bump netty to match version from core's buildSrc/version.properties and bump grpc to 1.56.1 #546

Closed cwperks closed 4 months ago

cwperks commented 4 months ago

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

This PR will match the build.gradle file on main here: https://github.com/opensearch-project/performance-analyzer-rca/blob/main/build.gradle#L373-L377

The dependencies on main should be updated or dependabot added to this repo if its not enabled already.

Without this change performance-analyzer-rca is being bundled with netty-codec-http-4.1.87.Final.jar, netty-codec-http2-4.1.87.Final.jar and netty-handler-4.1.87.Final.jar which are affected by https://avd.aquasec.com/nvd/cve-2024-29025, https://github.com/advisories/GHSA-xpw8-rcwv-8f8p and https://avd.aquasec.com/nvd/cve-2023-34462 respectively.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bbarani commented 4 months ago

@sgup432 can you please review it?

sgup432 commented 4 months ago

@cwperks I see main branch has implementation 'io.grpc:grpc-stub:1.52.1', do we need to update it to 1.56.1 there as well?

cwperks commented 4 months ago

@sgup432 Yes, main needs to be updated as well. I opened up a PR to add dependabot to automatically monitor for outdated dependencies and create PRs.

In the previous commit I made this PR exactly match main and it gave the following error:

Execution failed for task ':updateShas'.
> Could not resolve all dependencies for configuration ':runtimeClasspath'.
   > Conflict(s) found for the following module(s):
       - io.grpc:grpc-api between versions 1.56.1 and 1.52.1
     Run with:
         --scan or
         :dependencyInsight --configuration runtimeClasspath --dependency io.grpc:grpc-api
     to get more insight on how to solve the conflict.

ref: https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/8761123266/job/24047189857?pr=546