opensearch-project / performance-analyzer-rca

The Performance Analyzer RCA is a framework that builds on the Performance Analyzer engine to support root cause analysis (RCA) of performance and reliability problems for OpenSearch instances.
https://opensearch.org/docs/latest/monitoring-plugins/pa/rca/index/
Apache License 2.0
29 stars 56 forks source link

[BugFix] wrapped http createContext in try/catch #565

Closed atharvasharma61 closed 5 days ago

atharvasharma61 commented 2 months ago

Is your feature request related to a problem? Please provide an existing Issue # , or describe. resolved #545

Describe the solution you are proposing httpServer.createContext throws illegalArgumentException when called more than once for same parameters. This commit ensures to avoid such scenarios in the PerformanceAnalyzerApp main class by fixing the legacy parameter. This commit also ensures that the RcaController thread gracefully handles the similar situation when RcaController thread is killed and respawned.

Describe alternatives you've considered

Additional context Add any other context or screenshots about the feature request here.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ccxxcisco commented 3 weeks ago

@ansjcy @khushbr Hi, our project requires PA and is waiting this bug fixed. Could I know if this PR will be merged and released in 2.17.0?

ccxxcisco commented 6 days ago

@atharvasharma61 Hi, why did you close this PR?

@ansjcy @khushbr Why didn't you tend to solve this bug? Why you leave an obvious bug not fix for a so long time? Unbelieveable!

atharvasharma61 commented 6 days ago

This was closed accidently after doing a force push in the main branch. Will raise a fresh PR again. Apologies!