Closed CoderJeffrey closed 1 year ago
Merging #483 (59a78bc) into main (5428a52) will increase coverage by
0.18%
. The diff coverage is75.92%
.:exclamation: Current head 59a78bc differs from pull request most recent head 1a0b4ed. Consider uploading reports for the commit 1a0b4ed to get more accurate results
@@ Coverage Diff @@
## main #483 +/- ##
============================================
+ Coverage 73.67% 73.85% +0.18%
- Complexity 375 381 +6
============================================
Files 44 45 +1
Lines 2477 2693 +216
Branches 172 172
============================================
+ Hits 1825 1989 +164
- Misses 544 596 +52
Partials 108 108
Impacted Files | Coverage Δ | |
---|---|---|
...r/collectors/SearchBackPressureStatsCollector.java | 75.70% <75.70%> (ø) |
|
...performanceanalyzer/PerformanceAnalyzerPlugin.java | 77.14% <100.00%> (+0.21%) |
:arrow_up: |
...org/opensearch/performanceanalyzer/util/Utils.java | 92.50% <100.00%> (+0.19%) |
:arrow_up: |
In order to access the Constants field in this collector, another pull & request for performance-analyzer-commons package has been made.
Example:
@JsonProperty(SearchBackPressureStatsValue.Constants.SEARCHBP_NODEID) public String getSearchBackPressureStats_NodeId() { return this.nodeId; }
Parallel Pull & Request link: https://github.com/opensearch-project/performance-analyzer-commons/pull/33 Approving this pull & request will be needed in order for the collector to access the commons constant fields. Or else, error would occur.
Can we cleanup the bunch of jars which got along with the commit making the file changes as 37?
Can we cleanup the bunch of jars which got along with the commit making the file changes as 37?
Just cleaned up all jars.
Signed-off-by: Jeffrey Liu ujeffliu@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe. Add the functionality to gather the SearchBackPressure Service.
Describe the solution you are proposing Add SearchBackPressureStatsCollector.java to collect SearchBackPressure related metrics, and added Unit Testing for SearchBackPressureStatsCollector.java.
Describe alternatives you've considered N/A
Additional context
Changes in licenses/ are auto-created after running ./build gradlew
In order to access the Constants field in this collector, another pull & request for performance-analyzer-commons package has been made.
Example: @JsonProperty(SearchBackPressureStatsValue.Constants.SEARCHBP_NODEID) public String getSearchBackPressureStats_NodeId() { return this.nodeId; }
Parallel Pull & Request link: https://github.com/opensearch-project/performance-analyzer-commons/pull/33
Approving this pull & request will be needed in order for the collector to access the Performance-Analyzer-Commons Constants fields. Or else, error would occur.
Can verify the extracted search_back_pressure metrics in /dev/shm/performanceanalyzer directory, open any log file, and search for "search_back_pressure"
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.