Closed atharvasharma61 closed 3 months ago
https://pastecode.io/s/9bksb3ak Heap metrics
Hi @atharvasharma61! This looks like an interesting change, do we have any rfc/doc to provide more context?
Overall looks good, please address the open comments and build failures.
I am hoping there are changes in performance-analyzer-commons
package also in class ScheduledMetricCollectorsExecutor
. Please attache that PR also here.
One more thing to call-out: We need to enable delta temporality in Opensearch Otel. @Gaganjuneja
Please take a look at build failures.
Please take a look at build failures.
Dependent on PRs: https://github.com/opensearch-project/performance-analyzer/pull/657 and https://github.com/opensearch-project/performance-analyzer-commons/pull/74
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-651-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17611035b0519b96de809da2ccb07ea9b4107ede
# Push it to GitHub
git push --set-upstream origin backport/backport-651-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-651-to-2.x
.
Implementation and extension of Issue: #585
Code changes w.r.t. merging PA with Open Telemetry
Changes:
Dependent Changes: Commons-repo -> https://github.com/opensearch-project/performance-analyzer-commons/pull/74
Is your feature request related to a problem? Please provide an existing Issue # , or describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
Describe alternatives you've considered
Additional context
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.