Closed hxiao608 closed 3 years ago
Since we dont have automated testing. Can we manually test the artifact and confirm everything is working as expected? Please add the manual testing details as well to the PR. Thanks!
Perftop can now render metrics with the new _plugins
endpoint. The legacy mode will be able to render metrics after the setting up the Rest API BC for original _opendistro
endpoint .
Signoff by: Harold Xiao haoruxia@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing Add a new js file for setting and getting global properties, introduce a legacy flag to enable perfTop to run in a legacy mode, which will send out API request to opendistro endpoint
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.
Test Local build pass and succesfully test the new endpoint with the sample metrics command:
./build/opensearch-perf-top-macos --dashboard ${Dashboard} --endpoint localhost:9600
results:Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.