opensearch-project / reporting-cli

Apache License 2.0
4 stars 13 forks source link

Remove references to default credentials #56

Closed derek-ho closed 6 months ago

derek-ho commented 8 months ago

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DarshitChanpura commented 7 months ago

@derek-ho Can you update this line: https://github.com/opensearch-project/reporting-cli/blob/861b7ea6b6121ee3f019b8737df056ac95469d98/test/cli.js#L9 as well?

derek-ho commented 7 months ago

@Swiddis @sumukhswamy can you folks please help me with this? CI is failing since: https://github.com/opensearch-project/reporting-cli/pull/53. Turning this PR as draft since it should be merged after 2.12.0 release.

DarshitChanpura commented 6 months ago

Now that 2.12 is released this should be unblocked. Would one of the maintainers mind bringing it across the finish line?

rupal-bq commented 6 months ago

CI failure not related to this change