opensearch-project / reporting

Export and automate PNG, PDF, and CSV reports in OpenSearch Dashboards
https://opensearch.org/docs/latest/dashboards/reporting/
Apache License 2.0
28 stars 64 forks source link

Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors #1009

Closed cwperks closed 4 weeks ago

cwperks commented 1 month ago

Description

This PR registers the system indices in this plugin through the SystemIndexPlugin extension point in core. These indices will not be functionally different than they are today, its just a formal registration as a system index.

Issues Resolved

Related to: https://github.com/opensearch-project/security/issues/4439

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks commented 4 weeks ago

@derek-ho I pushed a commit to upgrade the baseVersion in this PR to fix the CI checks

derek-ho commented 4 weeks ago

@cwperks with the new base version bump I think the backport will fail/need further commits to revert, but I am fine as is.

derek-ho commented 4 weeks ago

@joshuali925 @Swiddis can we get this approved/merged?

opensearch-trigger-bot[bot] commented 4 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-1009-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f8177314e61ffca0e335a428c3c689aa6fbb2bb
# Push it to GitHub
git push --set-upstream origin backport/backport-1009-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/reporting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1009-to-2.x.