Closed msfroh closed 1 year ago
Merging #191 (3745363) into main (ae4088e) will decrease coverage by
0.14%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #191 +/- ##
============================================
- Coverage 83.39% 83.26% -0.14%
Complexity 334 334
============================================
Files 42 43 +1
Lines 1259 1261 +2
Branches 154 154
============================================
Hits 1050 1050
- Misses 132 134 +2
Partials 77 77
Files Changed | Coverage Δ | |
---|---|---|
...elevance/AmazonKendraIntelligentRankingPlugin.java | 0.00% <0.00%> (ø) |
|
...rch/relevance/actionfilter/SearchActionFilter.java | 85.45% <ø> (ø) |
|
...arch/search/relevance/client/OpenSearchClient.java | 80.00% <ø> (ø) |
|
...ch/relevance/configuration/ConfigurationUtils.java | 66.66% <ø> (ø) |
|
...arch/search/relevance/configuration/Constants.java | 80.00% <ø> (ø) |
|
.../configuration/ResultTransformerConfiguration.java | 100.00% <ø> (ø) |
|
...e/configuration/SearchConfigurationExtBuilder.java | 67.64% <ø> (ø) |
|
...evance/configuration/TransformerConfiguration.java | 100.00% <ø> (ø) |
|
.../search/relevance/transformer/TransformerType.java | 100.00% <ø> (ø) |
|
...draintelligentranking/KendraIntelligentRanker.java | 78.09% <ø> (ø) |
|
... and 33 more |
This PR also addresses refactoring done in OpenSearch core, which should fix the daily builds. Thanks for updating the imports as well! 🎉
Ignoring codecov, because it's confused about the coverage since it's ignoring all the moved files.
The backport to 2.9
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-191-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb77879e694ca609929b0c1098620a6ebea4afda
# Push it to GitHub
git push --set-upstream origin backport/backport-191-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9
Then, create a pull request where the base
branch is 2.9
and the compare
/head
branch is backport/backport-191-to-2.9
.
Description
We would like to be able to install a plugin that supports reranking with Amazon Personalize without automatically getting Amazon Kendra Intelligent Ranking too. Users should be able to choose which external reranker(s) they want to use and install plugins for each.
Issues Resolved
https://github.com/opensearch-project/search-processor/issues/190
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.