search

opensearch-project / security-analytics-dashboards-plugin

Front end (UI) plugin to support security-analytics
Apache License 2.0
10 stars 46 forks source link

[MDS][Part 1] Data source component added to all pages #1003

Closed amsiglan closed 4 months ago

amsiglan commented 5 months ago

Description

This PR adds the data source menu component to the chrome header for all the pages of security analytics. Below are screenshots of some pages

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

riysaxen-amzn commented 5 months ago

could you upload the video instead in the PR description, navigating all the pages. Thanks!

riysaxen-amzn commented 5 months ago

also, let's make sure CI passes

amsiglan commented 4 months ago

Overall, the changes LGTM.

Just to clarify, does the SAP frontend store a "cache" of alerts, findings, detectors, rules, etc.? If so, are those caches being refreshed when changing data sources? It's a little tough to tell from the code alone.

An unrefreshed cache of pre-packaged rules might not be immediately obvious since the names are the same across data sources; but if the IDs are not the same across data sources, detectors could fail if they reference ruleIDs that don't exist on that data source.

I do see we have some caching for the rules based on the query parameters. Let me re-evaluate and update it in the next PR where I actually connect the Data source menu with the logic to refresh the pages

amsiglan commented 4 months ago

also, let's make sure CI passes

@AWSHurneyt re-ran the test, but the failure wasn't related to the changes in this PR. Will investigate separately

amsiglan commented 4 months ago

https://github.com/opensearch-project/security-analytics-dashboards-plugin/assets/114732919/6b6cb879-4040-4572-9fa6-98240259c247

amsiglan commented 4 months ago

could you upload the video instead in the PR description, navigating all the pages. Thanks!

Done

riysaxen-amzn commented 4 months ago

could you upload the video instead in the PR description, navigating all the pages. Thanks!

Done

Also, when we load the page is the 'Local cluster' selected or the default dataSource? Expected behaviour is to have default one selected when the page loads

amsiglan commented 4 months ago

could you upload the video instead in the PR description, navigating all the pages. Thanks!

Done

Also, when we load the page is the 'Local cluster' selected or the default dataSource? Expected behaviour is to have default one selected when the page loads

Yes, the default DataSource is selected when the page loads