opensearch-project / security-analytics-dashboards-plugin

Front end (UI) plugin to support security-analytics
Apache License 2.0
8 stars 41 forks source link

Show all related docs for a finding #1006

Closed amsiglan closed 2 months ago

amsiglan commented 2 months ago

Description

Currently we only show on document for a finding in the flyout since the assumption was we only trigger a finding on one doc but with the introduction of aggregation rules support, we can now have a bucket of documents in a single finding. This PR updates the Finding flyout to show all the documents.

Existing UX: image

Proposed UX: image

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot[bot] commented 2 months ago

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-1006-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e16e1aaffe5bf207070a5d88e85daace6aca2707
# Push it to GitHub
git push --set-upstream origin backport-1006-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport-1006-to-2.11.