[BUG] `config.dynamic` fails on `opensearch-dashboards` key

AMoo-Miki commented 2 years ago

What is the bug? The config.yml honors outdated kibana key and throws an error for opensearch-dashboards.

How can one reproduce the bug? Steps to reproduce the behavior:

config:
  dynamic:
    opensearch-dashboards:
      server_username: kibanaserver

Dashboards fails with 15 known properties: "license", "disable_intertransport_auth", "http", "kibana", "authz", "auth_failure_listeners", "transport_userrname_attribute", "filtered_alias_mode", "authc", "disable_rest_auth", "respect_request_indices_options", "multi_rolespan_enabled", "do_not_fail_on_forbidden", "hosts_resolver_mode", "do_not_fail_on_forbidden_empty"]

What is the expected behavior? No errors to be shown and the setting to be honored.

Do you have any additional context? The documentation:

peternied commented 2 years ago

[Triage] Thanks for filing this issue @AMoo-Miki, it looks like this was miss when the new naming conventions were introduced

cliu123 commented 2 years ago

The old naming convention was kept to retain backward compatibility and allow ODFE users to migrate to OpenSearch. The change would be a breaking change, which might be suitable for 3.0.0.0 release.

opensearch-project / security-dashboards-plugin

[BUG] `config.dynamic` fails on `opensearch-dashboards` key #1030