Codeowners file is invalid

opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards

https://opensearch.org/docs/latest/security-plugin/index/

Apache License 2.0

70 stars 152 forks source link

Codeowners file is invalid #1883

Closed derek-ho closed 5 months ago

derek-ho commented 5 months ago

What is the bug? Seeing this error on CODEOWNERS file:

Unknown owner on line 1: make sure @davidlago exists and has write access to the repository
…123 @cwperks @DarshitChanpura @davidlago @derek-ho @peternied @RyanL1997 @scrawfor9

We should probably move Dave to emeritus maintainer and remove him from codeowner file.

What is the expected behavior? No error

cwperks commented 5 months ago

Thank you Derek. Do you plan to create a PR to address this issue?

derek-ho commented 5 months ago

Yes I will do so later today, I think security backend plugin also needs the same thing. I will create an issue and PR.

peternied commented 5 months ago

Let's make sure to get @davidlago's input on his status in the project before making changes

peternied commented 5 months ago

Let's make sure to get @davidlago's input on his status in the project before making changes. IMO there are two potential outcomes, 1) the permissions issue gets resolved and the file starts working again, 2) David chooses to become emeritus and he is removed from the codeowners (and maintainers.md is updated)

From https://github.com/opensearch-project/security/issues/4234

derek-ho commented 5 months ago

Yup. Confirmed with @davidlago this move to emeritus maintainer in a private conversation.