codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 69.22%. Comparing base (
5f0f592) to head (29d29ca).:exclamation: Current head 29d29ca differs from pull request most recent head 8865a8b. Consider uploading reports for the commit 8865a8b to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| ...ration/panels/role-edit/index-permission-panel.tsx | 66.66% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## feature/supporting-multiple-datasources #1894 +/- ## =========================================================================== - Coverage 69.23% 69.22% -0.02% =========================================================================== Files 96 96 Lines 2477 2479 +2 Branches 338 338 =========================================================================== + Hits 1715 1716 +1 Misses 683 683 - Partials 79 80 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
derek-ho
Description
Changes some code in the Roles tab and tries to find ways around flaky cypress test e2e multi-datasources enabled. Runs are consistently working on local, but fails due to cypress crashing on github runners.
Category
Maintenance
Why these changes are required?
Fix #1885
What is the old behavior before changes and new behavior after changes?
Cypress tests consistently crash and fail the multi datasources test, hopefully become more stable/passing afterwards.
Issues Resolved
Fix #1885
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.