opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
68 stars 148 forks source link

Fix issue when using OpenID Authentication with serverBasePath #1899

Closed cwperks closed 2 months ago

cwperks commented 3 months ago

Description

This PR fixes a bug where the security-dashboards-plugin would redirect back to / instead of /{serverBasePath} after authenticating with OpenID.

This PR also performs all SAML, OpenID and Multi-auth cypress tests both without a basePath and with a basePath

Category

Bug Fix

Issues Resolved

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.94%. Comparing base (347f579) to head (bd82997).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1899 +/- ## ======================================= Coverage 69.94% 69.94% ======================================= Files 97 97 Lines 2505 2505 Branches 336 343 +7 ======================================= Hits 1752 1752 Misses 672 672 Partials 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cwperks commented 2 months ago

@DarshitChanpura Replied to both outstanding comments. I was not able to figure out a way to reduce it to a single step. Can those be addressed in a follow-up PR?