search

opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
66 stars 148 forks source link

[BUG] Tenant Tab behavior when Local Cluster is disabled #1933

Closed derek-ho closed 2 months ago

derek-ho commented 2 months ago

What is the bug? When local cluster is disabled, the "tenant" tab is still pulling info from the local cluster - this is because this tab is locked to the local cluster even when there are external clusters due to dashboards confusion - this needs to be addressed - either show empty data on this tab or remove the tab altogether when local cluster is disabled.

derek-ho commented 2 months ago

@kgcreative can you add any comments here on what is the expected behavior here?

kgcreative commented 2 months ago

This is not a bug and is as intended. The local cluster being disabled means we don't want to use the indexes on the local cluster for data analysis, but the local cluster is the compute for OSD instead. We should probably omit the data source picker for multitenancy in general, since it's OSD multi tenancy, and not backend multitenancy

derek-ho commented 2 months ago

This is not a bug and is as intended. The local cluster being disabled means we don't want to use the indexes on the local cluster for data analysis, but the local cluster is the compute for OSD instead. We should probably omit the data source picker for multitenancy in general, since it's OSD multi tenancy, and not backend multitenancy

Sure we can remove the picker from this tab overall. I get what you are saying, but I still think it is an edge case - when local cluster is hidden, the picker shows like this - an empty state, but it is still pulling data from the local cluster. @kgcreative so final call is to just remove the picker from this tab all together?

Screenshot 2024-04-30 at 12 43 14 PM
scrawfor99 commented 2 months ago

[Triage] Hi @derek-ho thanks for filing this issue. It looks like you opened a PR to resolve this and are working with Kevin to take the best approach for handling things. Going to marked as triaged.

kgcreative commented 2 months ago

Ideally we should show a read-only single-select state showing the local cluster (for consistency sake), rather than removing local cluster. I think we need to show local cluster in security regardless of whether the local cluster is disabled, since that's how that will allow customers to do things like setup auth, create users, roles, etc for opensearch dashboards when security is enabled.