Open derek-ho opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.61%. Comparing base (
293490d
) to head (e23196a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems like it is getting stuck on permissions spec, going to check that right now, specifically: should open modal with options to create new action group page
Looks like it may just be timing out I need to double check this
The fix for the above issue is here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7163
Fix got merged, and re-running all the CI jobs
@derek-ho do we need to complete https://github.com/opensearch-project/security-dashboards-plugin/issues/2005 and associated reversion in FTR to avoid this state where main shows one label and 2.x shows a separate label?
Description
This PR adds running all the associated FTR tests on every PR getting merged into the security dashboards plugin. This will raise awareness of the implicit connection here, and also let contributors know when their change needs to make a corresponding test in the FTR, instead of waiting until release time to figure this out.
Category
Enhancement
Why these changes are required?
Fix: #1936
What is the old behavior before changes and new behavior after changes?
Before: not all FTR tests were being run After: now, all tests run during release time are run with every raised PR
Issues Resolved
Close: #1936
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.