Closed derek-ho closed 1 month ago
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 69.91%. Comparing base (
e41d4d0
) to head (6e4a575
).
Files | Patch % | Lines |
---|---|---|
...s/configuration/panels/tenant-list/tenant-list.tsx | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why are we reverting this?
Why are we reverting this?
Added context in the description
Thank you for updating the description @derek-ho !
@derek-ho Can you check code-cov failures once to determine if any tests are necessary?
@derek-ho Can you check code-cov failures once to determine if any tests are necessary?
I think it's fine, the test change also works and its a one-liner. Merging as is.
Reverts opensearch-project/security-dashboards-plugin#1937
Edit: Adding more context here. The reason for this revert is @kgcreative's comment here: https://github.com/opensearch-project/security-dashboards-plugin/issues/1933#issuecomment-2101742784. Ideally, this tab should have the picker locked to the local cluster to maintain the same look across the plugin. Core doesn't have any plan to implement this, so we will add this back, and call it a user mis-configuration if that decide to hide the local cluster. Since security plugin is more of an admin view, when they visit they should have local cluster enabled.