Closed derek-ho closed 1 month ago
Attention: Patch coverage is 45.83333%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 69.91%. Comparing base (
37c2695
) to head (9404930
).
Files | Patch % | Lines |
---|---|---|
public/apps/configuration/app-router.tsx | 57.89% | 7 Missing and 1 partial :warning: |
public/apps/configuration/panels/get-started.tsx | 0.00% | 4 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Failing cypress test case should be changed to instead assert that tenancy tab does not show up on the left nav menu. That test is not being run at release time, will move that over in a separate PR
Test fix is within this PR: https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1276
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1960-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a202d4875ae42729994b64fb38090af6b7f1ae7a
# Push it to GitHub
git push --set-upstream origin backport/backport-1960-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-1960-to-2.x
.
@derek-ho Could you create a manual backport?
Description
Removes tenant tab from showing up in the left nav, and also doesn't register it as a page at
/tenants
if tenancy is turned off/not enabled via yaml. Since workspaces is coming and no active development being done on the tenancy feature, this is appropriate. Also gets rid of a few "ghost" routes and UI components related to different tenancy tabs (manage vs configure), since these were not connected to any UI component and would only be hit unexpectedly or if people know the exact route to put in the URL.Category
Enhancement
Why these changes are required?
Fix: https://github.com/opensearch-project/security-dashboards-plugin/issues/1959
What is the old behavior before changes and new behavior after changes?
New behavior: when multi tenancy is turned off via dashboards yaml, tenancy does not show up in the left nav, explicitly navigating to '/tenants' does not do anything
Issues Resolved
Fix: https://github.com/opensearch-project/security-dashboards-plugin/issues/1959
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.