codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 31.03448% with 20 lines in your changes are missing coverage. Please review.
Project coverage is 69.94%. Comparing base (
37c2695) to head (002b3d3). Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| public/plugin.ts | 31.03% | 20 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1963 +/- ## ========================================== + Coverage 69.91% 69.94% +0.03% ========================================== Files 97 96 -1 Lines 2506 2519 +13 Branches 336 351 +15 ========================================== + Hits 1752 1762 +10 - Misses 673 674 +1 - Partials 81 83 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Introduces an
opensearch_dashboards.ymlsetting to be able to disable Security from the menu for all users. The setting isopensearch_security.configuration.admin_pages_enabled, is true by default and needs to be explicitly disabled.Currently, the behavior is to display Security in the main menu only for a Security admin user. To determine whether a user is a Security admin, security-dashboards-plugin runs an API request and determines if the logged in user is mapped to one of the
plugins.security.restapi.roles_enabledroles.Category
Enhancement
Issues Resolved
Testing
Manual testing to ensure disabling the Security screens doesn't cause any other issues. The user still needs to be able to reset their password, view their user info and switch tenants.
Marking this as Draft until functional tests are added.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.