Closed derek-ho closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.61%. Comparing base (
b3e444f
) to head (dd9cde3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks that is a good suggestion - here is how it looks with the new addition on the login screen
@cwperks @DarshitChanpura I decided to also remove the macos unit tests check since we dont officially support mac os and this can cut down on CI time spent/overall resources used, but it seems to be a required check - what do you folks think about removing this until/if we support macos officially?
@derek-ho updated the branch protection rules. main now matches 2.. There was an issue where Unit tests for Mac OS were required, but Unit tests for Windows were not. On 2. it required Unit Tests to run successfully for Windows so I updated the rules on main to match.
Description
Previously, there is no way to view the password that a user types when creating a user or resetting the password. This could be frustrating if the password is long and cannot be updated without retyping the whole thing. This PR adds that ability.
Category
Enhancement
Why these changes are required?
To improve the user experience
What is the old behavior before changes and new behavior after changes?
https://github.com/opensearch-project/security-dashboards-plugin/assets/26328171/c71df760-f87b-4329-adc9-1c23ddb6f3b5
Issues Resolved
Fix: https://github.com/opensearch-project/security-dashboards-plugin/issues/1940
Testing
Snapshot test, video
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.