opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
70 stars 152 forks source link

[Backport 2.x] Always show security screen and shows error page when trying to access forbidden data-source (#1964) #1984

Closed DarshitChanpura closed 4 months ago

DarshitChanpura commented 4 months ago

Description

Manually backports #1964

Manual backport is required because:

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 59.48276% with 47 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (33ea906) to head (826380a).

Files Patch % Lines
...onfiguration/panels/tenant-list/configure_tab1.tsx 25.00% 10 Missing and 2 partials :warning:
public/apps/configuration/panels/user-list.tsx 46.15% 4 Missing and 3 partials :warning:
public/apps/configuration/app-router.tsx 25.00% 6 Missing :warning:
public/apps/configuration/panels/role-list.tsx 40.00% 2 Missing and 4 partials :warning:
.../apps/configuration/panels/auth-view/auth-view.tsx 68.75% 4 Missing and 1 partial :warning:
...uration/panels/permission-list/permission-list.tsx 69.23% 3 Missing and 1 partial :warning:
...blic/apps/configuration/access-error-component.tsx 66.66% 1 Missing and 1 partial :warning:
...ps/configuration/panels/tenant-list/manage_tab.tsx 77.77% 1 Missing and 1 partial :warning:
...s/configuration/panels/tenant-list/tenant-list.tsx 50.00% 1 Missing :warning:
public/apps/configuration/top-nav-menu.tsx 75.00% 0 Missing and 1 partial :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #1984 +/- ## ========================================== + Coverage 69.60% 70.36% +0.76% ========================================== Files 95 96 +1 Lines 2461 2541 +80 Branches 332 377 +45 ========================================== + Hits 1713 1788 +75 + Misses 666 660 -6 - Partials 82 93 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

derek-ho commented 4 months ago

We should delete service accounts on main if we have no plans to move forward with it, to prevent these pesky backport failures

DarshitChanpura commented 4 months ago

Argh, good catch. Removed those files.