Make login screen input feels consistent

opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards

https://opensearch.org/docs/latest/security-plugin/index/

Apache License 2.0

66 stars 147 forks source link

Make login screen input feels consistent #1993

Closed AMoo-Miki closed 3 weeks ago

AMoo-Miki commented 3 weeks ago

Description

Ran this by @kgcreative.

Turns

Into

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Prior to #1980, we had

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.61%. Comparing base (9abc57d) to head (579dbd1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1993 +/- ## ======================================= Coverage 70.61% 70.61% ======================================= Files 97 97 Lines 2600 2600 Branches 387 380 -7 ======================================= Hits 1836 1836 Misses 668 668 Partials 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kgcreative commented 3 weeks ago

Hi @RyanL1997 -- since the password field uses the input icon field instead of pre-pend, and the icon style is also consistent with search type fields, the style as Miki has updated it is internally consistent. Append makes sense for show/hide, but we made an explicit call here to move away from using both append and prepend for the login and password fields.