opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
66 stars 147 forks source link

Fix URL duplication issue #2004

Closed derek-ho closed 2 weeks ago

derek-ho commented 3 weeks ago

Description

This PR fixes a duplication issue where upon first navigation to the security dashboards plugin, the /app/security-dashboards-plugin#/ segment would appear twice.

Category

Bug Fix

Why these changes are required?

Bug Fix

What is the old behavior before changes and new behavior after changes?

See video here: https://github.com/opensearch-project/security-dashboards-plugin/pull/2004#issuecomment-2166445743

Issues Resolved

Fix: #1967

Testing

Manual testing

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.61%. Comparing base (208089e) to head (32c0b81).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2004 +/- ## ======================================= Coverage 70.61% 70.61% ======================================= Files 97 97 Lines 2600 2600 Branches 380 387 +7 ======================================= Hits 1836 1836 Misses 668 668 Partials 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

derek-ho commented 3 weeks ago

https://github.com/opensearch-project/security-dashboards-plugin/assets/26328171/69049d02-42a6-45e4-9e9f-42683e9b7045