opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
70 stars 152 forks source link

Remove AOSS options from the data source selector #2016

Closed derek-ho closed 2 months ago

derek-ho commented 3 months ago

Description

This change removes AOSS data sources from the data source selector. Security is not supported for these data sources, so they should not be shown in the security plugin.

Category

Enhancement

Why these changes are required?

Fix: #2011

What is the old behavior before changes and new behavior after changes?

AOSS data sources used to show up in the selector, now they don't.

Issues Resolved

Fix: #2011

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (757f4ce) to head (25bdd36).

Files Patch % Lines
public/apps/configuration/top-nav-menu.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2016 +/- ## ========================================== - Coverage 70.61% 70.58% -0.03% ========================================== Files 97 97 Lines 2600 2601 +1 Branches 380 387 +7 ========================================== Hits 1836 1836 - Misses 668 669 +1 Partials 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

derek-ho commented 3 months ago

Blocked on: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7154

derek-ho commented 2 months ago

This PR is blocked on: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7261

derek-ho commented 2 months ago

Closing for now until core supports it