opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
68 stars 148 forks source link

Conform to Navigation changes from OSD core #2022

Closed derek-ho closed 1 day ago

derek-ho commented 2 weeks ago

Description

Adopts to nav changes in core when a feature flag is enabled

Category

Enhancement

Why these changes are required?

Fix: #2020

What is the old behavior before changes and new behavior after changes?

https://github.com/user-attachments/assets/30c7dab9-2b7d-4006-a3bf-b8cad97b2e03

The first part of the video is the current behavior and the behavior with the feature flag off, the second part of the video is the new behavior with the feature flag on.

Issues Resolved

Fix: #2020

Testing

Manual testing. Since the feature branch is not yet merged in core and many of the API calls are simply registration calls from exposed APIs code tests don't seem feasible.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 22.22222% with 42 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (fe847af) to head (4eade76).

Files Patch % Lines
public/plugin.ts 5.00% 38 Missing :warning:
public/utils/datasource-utils.ts 66.66% 2 Missing and 1 partial :warning:
public/apps/configuration/top-nav-menu.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2022 +/- ## ========================================== - Coverage 70.36% 69.34% -1.02% ========================================== Files 96 96 Lines 2541 2587 +46 Branches 377 375 -2 ========================================== + Hits 1788 1794 +6 - Misses 660 699 +39 - Partials 93 94 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.