opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
71 stars 161 forks source link

Ux fixes for page header #2108

Closed derek-ho closed 2 months ago

derek-ho commented 2 months ago

Description

This PR fixes a few issues with the UX for the new page header/home feature flag. It does the following:

Category

Enhancement

Why these changes are required?

Fix: opensearch-project/OpenSearch-Dashboards#2106

What is the old behavior before changes and new behavior after changes?

See screenshots

Issues Resolved

Fix: opensearch-project/OpenSearch-Dashboards#2106

Testing

Existing tests pass, updated snapshots

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.40%. Comparing base (c143bce) to head (9949cb6). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
public/apps/configuration/app-router.tsx 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main opensearch-project/OpenSearch-Dashboards#2108 +/- ## ========================================== + Coverage 71.39% 71.40% +0.01% ========================================== Files 97 97 Lines 2650 2651 +1 Branches 403 404 +1 ========================================== + Hits 1892 1893 +1 Misses 642 642 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

derek-ho commented 2 months ago

Created issue here for binary failure: https://github.com/opensearch-project/security-dashboards-plugin/issues/2118

derek-ho commented 2 months ago
Screenshot 2024-08-29 at 10 08 30 AM Screenshot 2024-08-29 at 11 24 23 AM Screenshot 2024-08-29 at 11 24 09 AM