Fix button label - Githubissues

opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards

https://opensearch.org/docs/latest/security-plugin/index/

Apache License 2.0

71 stars 161 forks source link

Fix button label #2130

Closed derek-ho closed 1 month ago

derek-ho commented 1 month ago

Description

Fixes the button label for config.yml documentation on the "Get Started" page

Why these changes are required?

Fix: #2129

What is the old behavior before changes and new behavior after changes?

Used to say "Create config.yml", now it says "Config.yml documentation"

Issues Resolved

Fix: #2129

Testing

Existing tests pass

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.40%. Comparing base (5495990) to head (8f83c1e). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2130 +/- ## ======================================= Coverage 71.40% 71.40% ======================================= Files 97 97 Lines 2651 2651 Branches 404 411 +7 ======================================= Hits 1893 1893 Misses 642 642 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RyanL1997 commented 1 month ago

Just wanna share one of the solutions we are thinking in observability dashboards: https://github.com/opensearch-project/dashboards-observability/pull/2187. So basically we added a specific step for compilation. cc @Swiddis