opensearch-project / security-dashboards-plugin

🔐 Manage your internal users, roles, access control, and audit logs from OpenSearch Dashboards
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
71 stars 159 forks source link

Kerberos Auth does not exist #907

Open Naarcha-AWS opened 2 years ago

Naarcha-AWS commented 2 years ago

Is your feature request related to a problem? Please describe.

Upon investigation, it seems like Kerberos authentication was not added to Security Dashboard Plugin, despite existing in OpenSearch. Specifically, according to Eliatra, the Dashboards plugin did not include a full fork of the Search Guard plugin. Instead, the contents of the fork were recreated piece by piece, with OIDC, SAML, and basic auth implemented incrementally (https://github.com/opensearch-project/security-dashboards-plugin/tree/main/server/auth/types vs https://git.floragunn.com/search-guard/search-guard-kibana-plugin/-/tree/master/server/applications/searchguard/auth/types).

This will prove to be a significant blocker for users, as evidence by the following issue from the Documentation repo (https://github.com/opensearch-project/documentation-website/issues/398#issuecomment-1044506657).

Describe the solution you'd like

Implement the full Search Guard plugin into the Dashboard's plugin. Or, implement Kerberos authentication into the plugin.

melokk97 commented 2 years ago

Any updates on this?

mercury131 commented 2 years ago

Can you tell when this issue will be resolved? Because of this bug it is impossible to use kerberos in opensearch. If I set order 0 for kerberos in security plugin config, opensearch dashboards can't authorize anymore.

gpchelkin commented 2 years ago

Kerberos auth is widely used in my environment. It would be great if you fix it in the near future.

denMko commented 2 years ago

It would be great to use kerberos auth with dashboards, so.. Сan we wait the fix in the near future/release?

samuelcostae commented 1 year ago

I've started looking into this @scrawfor99 . Commenting so it can be assigned.

samuelcostae commented 1 year ago

Had to leave this for a bit to focus on other issues, but started again last week and now started to working on testing

samuelcostae commented 1 year ago

Im currently working on Unit tests.

Regarding integration testing , like we mentioned in the last call, we were discussing if would be worth it to have integration tests in dashboards as there isn't much logic/ code involved and most of the authentication of process is done by the browser, the kerberos KDC and the Kerberos configuration on the user machine.

It seems that the backend security plugin doesn't have tests for Kerberos, so it could be the case the effort would better applied in adding the tests to the backend?

Any thoughts on this?

@jochen-kressin feel free to add to my summary of the scenario

davidlago commented 1 year ago

@samuelcostae could we get a description of the current situation and proposed changes with pros/cons of the approach and different testing strategies? that way we'll be able to make a call to move forward. Thanks!

samuelcostae commented 1 year ago

I will try to be more specific

Proposal 1: Only do unit tests for Dashboards integration Pros:

Proposal 2: Do full Integration tests for Dashboards Pros:

peternied commented 1 year ago

@samuelcostae Thanks for looking into this. We shouldn't invest any effort into this space right now. Without end to end validation we cannot know if the feature works and we don't have a strong commitment (sadly) to invest in this space. As much as it pains me that we aren't investing into kerberos, this isn't the right time with the other considerations.

Nihlus commented 7 months ago

Are there any plans to revisit this? Having Kerberos support is quite important for single sign-on, especially in an LDAP/FreeIPA environment where external SSO alternatives are relatively limited.

derek-ho commented 5 months ago

We do have plans to implement this. I create an issue regarding adding tests verifying the existing backend functionality: https://github.com/opensearch-project/security/issues/4447. Then we can move forward on implementation for OpenSearch Dashboards @Nihlus

Nihlus commented 5 months ago

That's excellent news, thank you :)