search

opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
192 stars 274 forks source link

Code Coverage detects setters #2868

Open MaciejMierzwa opened 1 year ago

MaciejMierzwa commented 1 year ago

What is the bug? Codecov detects setters and brings down total % of coverage. Those methods don't contain any logic, it would be safe to exclude it from coverage.

How can one reproduce the bug? Steps to reproduce the behavior:

  1. Add new fields, getters, setters to POJO class
  2. Create PR
  3. Wait for codecov to finish alalysis Example: ConfigV6, ConfigV7: https://github.com/opensearch-project/security/pull/2805/checks?check_run_id=14286199969

What is the expected behavior? Codecov shouldn't detect one-line setters without logic. Screenshots image

stephen-crawford commented 1 year ago

[Triage] Hi @MaciejMierzwa, thank you for filing this issue. This is definitely a good issue and we would definitely appreciate suggested alternatives or PRs to address this.