search

opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
181 stars 264 forks source link

[Backport 2.x] Refactor ActionGroup REST API test and partial fix #4166 (#4371) #4388

Closed willyborankin closed 1 month ago

willyborankin commented 1 month ago

Manual backport e455aa1c3e02b322531a16b940e1f70d23ea0092 from #4371. The reason is the conflict with the deleted ActionGroupsApiTest class

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.31%. Comparing base (5431c0b) to head (71bca94).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4388/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## 2.x #4388 +/- ## ========================================== - Coverage 65.38% 65.31% -0.07% ========================================== Files 309 309 Lines 21818 21819 +1 Branches 3545 3545 ========================================== - Hits 14265 14251 -14 - Misses 5791 5804 +13 - Partials 1762 1764 +2 ``` | [Files](https://app.codecov.io/gh/opensearch-project/security/pull/4388?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [.../security/dlic/rest/api/ActionGroupsApiAction.java](https://app.codecov.io/gh/opensearch-project/security/pull/4388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Fsecurity%2Fdlic%2Frest%2Fapi%2FActionGroupsApiAction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC9zZWN1cml0eS9kbGljL3Jlc3QvYXBpL0FjdGlvbkdyb3Vwc0FwaUFjdGlvbi5qYXZh) | `67.44% <0.00%> (-30.18%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4388/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)