search

opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
191 stars 272 forks source link

Adds validation for the action groups type key #4400

Closed willyborankin closed 3 months ago

willyborankin commented 4 months ago

Description

Added validation for the action groups type key.

Issues Resolved

4374

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.42%. Comparing base (f002182) to head (2689aaf). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4400/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## main #4400 +/- ## ========================================== + Coverage 65.39% 65.42% +0.02% ========================================== Files 310 310 Lines 21993 22005 +12 Branches 3554 3556 +2 ========================================== + Hits 14383 14397 +14 + Misses 5838 5837 -1 + Partials 1772 1771 -1 ``` | [Files](https://app.codecov.io/gh/opensearch-project/security/pull/4400?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [.../security/dlic/rest/api/ActionGroupsApiAction.java](https://app.codecov.io/gh/opensearch-project/security/pull/4400?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Fsecurity%2Fdlic%2Frest%2Fapi%2FActionGroupsApiAction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC9zZWN1cml0eS9kbGljL3Jlc3QvYXBpL0FjdGlvbkdyb3Vwc0FwaUFjdGlvbi5qYXZh) | `78.18% <100.00%> (+10.73%)` | :arrow_up: |
willyborankin commented 3 months ago

Changes look good to me @willyborankin. Can you check the code-cov annotations? I think we should add a test that covers the deprecation message.

Fixed.