Check block request only if system index

[10000-ki]

Description

• Category : Bug Fix
• Why these changes are required? : There was an issue where documents could not be queried without system index permissions, even if the index was not a system index. This has been fixed.
• What is the old behavior before changes and new behavior after changes?
  • old : Documents could not be searched without system index permissions when plugins.security.system_indices.permission.enabled enabled
  • new : Documents in normal indexes can always be searched regardless of system index permissions.

Issues Resolved

issue: https://github.com/opensearch-project/security/issues/4429

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

• [x] New functionality includes testing
• [ ] New functionality has been documented
• [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[willyborankin]

@10000-ki could you plz rebase? The main branch contains fix for the DelegatingRestHandlerTests test

[10000-ki]

@willyborankin thank you I have rebased my branch.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.48%. Comparing base (c1872b6) to head (be1bb75). Report is 4 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/opensearch-project/security/pull/4430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## main #4430 +/- ## ========================================== + Coverage 65.44% 65.48% +0.03% ========================================== Files 312 312 Lines 22042 22040 -2 Branches 3559 3559 ========================================== + Hits 14425 14432 +7 + Misses 5843 5837 -6 + Partials 1774 1771 -3 ``` | [Files](https://app.codecov.io/gh/opensearch-project/security/pull/4430?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [...ty/configuration/SecurityIndexSearcherWrapper.java](https://app.codecov.io/gh/opensearch-project/security/pull/4430?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Fsecurity%2Fconfiguration%2FSecurityIndexSearcherWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC9zZWN1cml0eS9jb25maWd1cmF0aW9uL1NlY3VyaXR5SW5kZXhTZWFyY2hlcldyYXBwZXIuamF2YQ==) | `94.73% <100.00%> (+0.29%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4430/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)

[10000-ki]

@cwperks @willyborankin Oh.. I have enhanced the test cases, and the approval was removed. I'm sorry, but could I please ask you to review this pr again?

[willyborankin]

@cwperks @willyborankin Oh.. I have enhanced the test cases, and the approval was removed. I'm sorry, but could I please ask you to review this pr again?

@10000-ki, will do during the day