Closed nibix closed 2 weeks ago
@peternied @cwperks @reta I am getting test failures on DelegatingRestHandlerTests
- I guess this is a regression caused by the changes done in https://github.com/opensearch-project/OpenSearch/pull/13772 to RestHandler
. I guess this can be fixed by adding supportsStreaming()
to DelegatingRestHandler
.
@peternied @cwperks @reta I am getting test failures on DelegatingRestHandlerTests
Fixing it right away, thank you @nibix
@reta Thanks for the quick fix!
@peternied @reta I am getting now another CI failure where I am a bit lost. Maybe someone of you has an idea?
* Where:
Build file '/home/runner/work/security/security/build.gradle' line: 473
* What went wrong:
A problem occurred evaluating root project 'opensearch-security'.
> Cannot change resolution strategy of dependency configuration ':runtimeClasspath' after it has been resolved.
However, gradlew assemble
on my own system runs fine.
@peternied @reta I am getting now another CI failure where I am a bit lost. Maybe someone of you has an idea?
@nibix fix is coming shortly , very unfortunate you run into those, apologies for that
I ran into more CI issues, a fix is here: #4446
@nibix I'm not sure why some of the tests have not run. Can you rebase and push to see if it kicks off the CI checks? I'm not able to force start them.
@cwperks Done, but we had again test failures in a windows job. Would you mind to restart this one again?
Attention: Patch coverage is 60.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 65.43%. Comparing base (
c1872b6
) to head (3817416
).
Description
This code change is just in preparation for the change in #4380 as requested in https://github.com/opensearch-project/security/pull/4380#discussion_r1621325450 .
In the course of #4380 , the
SecurityRoles
class will be replaced by a new concept. This PR already replaces the usages ofSecurityRoles
where no methods are used on it except thegetRoleNames()
method. This method call can be easily replaced by theSet<String> mappedRoles
, which is computed byPrivilegesEvaluator
before theSecurityRoles
instance is created. This change elliminated the coupling of the interfaces that consume that information to theSecurityRoles
class, thereby enhancing code quality.SecurityRoles
class in the end.Issues Resolved
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.