search

opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
180 stars 263 forks source link

Fixes flaky integration tests #4452

Closed willyborankin closed 2 weeks ago

willyborankin commented 2 weeks ago

Description

AbstractDefaultConfigurationTests used configurationFolder as a constant as result all inherited tests could use the same config folder which can be cleaned unpredictably.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

willyborankin commented 2 weeks ago

Looks a bit better now.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.47%. Comparing base (c1872b6) to head (bb4a2d3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4452/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## main #4452 +/- ## ========================================== + Coverage 65.44% 65.47% +0.03% ========================================== Files 312 312 Lines 22042 22042 Branches 3559 3559 ========================================== + Hits 14425 14433 +8 + Misses 5843 5837 -6 + Partials 1774 1772 -2 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4452/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)
shikharj05 commented 2 weeks ago

@willyborankin Good find! Thank you for fixing this :)