opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
180 stars 263 forks source link

Add Tenants REST API test and partial fix #4166 #4465

Closed willyborankin closed 1 week ago

willyborankin commented 2 weeks ago

Description

Added Tenants REST API test

Issues Resolved

partial fix #4166

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.27%. Comparing base (962eafa) to head (aa932f5).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4465/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## main #4465 +/- ## ========================================== - Coverage 65.27% 65.27% -0.01% ========================================== Files 313 313 Lines 22057 22058 +1 Branches 3563 3563 ========================================== Hits 14398 14398 - Misses 5888 5889 +1 Partials 1771 1771 ``` | [Files](https://app.codecov.io/gh/opensearch-project/security/pull/4465?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [...earch/security/dlic/rest/api/TenantsApiAction.java](https://app.codecov.io/gh/opensearch-project/security/pull/4465?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Fsecurity%2Fdlic%2Frest%2Fapi%2FTenantsApiAction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC9zZWN1cml0eS9kbGljL3Jlc3QvYXBpL1RlbmFudHNBcGlBY3Rpb24uamF2YQ==) | `38.88% <0.00%> (-2.29%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4465/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)
willyborankin commented 1 week ago

Changes look good to me. @willyborankin would you please check why is code-cov complaining?

Well codecov/patch shows wrong info about hidden/reserved properties, since they covered in the AbstractConfigEntityApiIntegrationTest