opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
180 stars 263 forks source link

Update PR template to raise awareness of security dashboards plugin static list #4476

Closed derek-ho closed 1 week ago

derek-ho commented 1 week ago

Description

This PR updates the PR template to add awareness around opening a corresponding PR in the security dashboards repo when adding new roles/permissions.

Issues Resolved

Fix: #4330

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.29%. Comparing base (1d1b1ed) to head (20a5ec8). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4476/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## main #4476 +/- ## ========================================== + Coverage 65.25% 65.29% +0.04% ========================================== Files 312 313 +1 Lines 22035 22058 +23 Branches 3560 3563 +3 ========================================== + Hits 14379 14403 +24 + Misses 5888 5885 -3 - Partials 1768 1770 +2 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4476/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)
reta commented 1 week ago

@derek-ho DCO check is failing sadly :(