opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
180 stars 263 forks source link

[Backport 2.x] Refactor Role Mappings REST API test (#4450) #4492

Closed willyborankin closed 4 days ago

willyborankin commented 4 days ago

Backport 6dedfb455766601b1fdee8e5334cd0905bfe2ed2 deom #4450

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.34%. Comparing base (abf0be8) to head (71073e8).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4492/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4492?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## 2.x #4492 +/- ## ========================================== - Coverage 65.36% 65.34% -0.02% ========================================== Files 312 312 Lines 21876 21878 +2 Branches 3549 3549 ========================================== - Hits 14300 14297 -3 - Misses 5805 5811 +6 + Partials 1771 1770 -1 ``` | [Files](https://app.codecov.io/gh/opensearch-project/security/pull/4492?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [.../security/dlic/rest/api/RolesMappingApiAction.java](https://app.codecov.io/gh/opensearch-project/security/pull/4492?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Fsecurity%2Fdlic%2Frest%2Fapi%2FRolesMappingApiAction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC9zZWN1cml0eS9kbGljL3Jlc3QvYXBpL1JvbGVzTWFwcGluZ0FwaUFjdGlvbi5qYXZh) | `94.11% <75.00%> (-2.76%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4492/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)