opensearch-project / security

🔐 Secure your cluster with TLS, numerous authentication backends, data masking, audit logging as well as role-based access control on indices, documents, and fields
https://opensearch.org/docs/latest/security-plugin/index/
Apache License 2.0
191 stars 272 forks source link

OIDC ogging change #4516

Closed stephen-crawford closed 1 month ago

stephen-crawford commented 3 months ago

Description

[Describe what this change achieves] Work in progress, please ignore--it is helpful to have some of the runners validate testing etc.

Issues Resolved

[List any issues this PR will resolve]

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (6dedfb4) to head (f91fdcc). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/security/pull/4516/graphs/tree.svg?width=650&height=150&src=pr&token=rBpySfQXMt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/security/pull/4516?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## main #4516 +/- ## ========================================== - Coverage 65.21% 65.16% -0.06% ========================================== Files 313 313 Lines 22047 22084 +37 Branches 3559 3566 +7 ========================================== + Hits 14378 14391 +13 - Misses 5895 5914 +19 - Partials 1774 1779 +5 ``` | [Files](https://app.codecov.io/gh/opensearch-project/security/pull/4516?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [.../org/opensearch/security/user/AuthCredentials.java](https://app.codecov.io/gh/opensearch-project/security/pull/4516?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Fsecurity%2Fuser%2FAuthCredentials.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC9zZWN1cml0eS91c2VyL0F1dGhDcmVkZW50aWFscy5qYXZh) | `72.36% <75.00%> (+1.35%)` | :arrow_up: | | [...azon/dlic/auth/http/jwt/keybyoidc/JwtVerifier.java](https://app.codecov.io/gh/opensearch-project/security/pull/4516?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Famazon%2Fdlic%2Fauth%2Fhttp%2Fjwt%2Fkeybyoidc%2FJwtVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9jb20vYW1hem9uL2RsaWMvYXV0aC9odHRwL2p3dC9rZXlieW9pZGMvSnd0VmVyaWZpZXIuamF2YQ==) | `76.47% <76.92%> (-3.53%)` | :arrow_down: | | [...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java](https://app.codecov.io/gh/opensearch-project/security/pull/4516?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Famazon%2Fdlic%2Fauth%2Fhttp%2Fjwt%2FAbstractHTTPJwtAuthenticator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9jb20vYW1hem9uL2RsaWMvYXV0aC9odHRwL2p3dC9BYnN0cmFjdEhUVFBKd3RBdXRoZW50aWNhdG9yLmphdmE=) | `53.78% <35.13%> (-6.66%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/security/pull/4516/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)