Fix build error due to upstream change

opensearch-project / skills

Apache License 2.0

6 stars 29 forks source link

Fix build error due to upstream change #316

Closed Hailong-am closed 4 months ago

Hailong-am commented 4 months ago

Description

Fix build error due to upstream changes https://github.com/opensearch-project/common-utils/pull/655 https://github.com/opensearch-project/anomaly-detection/pull/1210

Issues Resolved

https://github.com/opensearch-project/skills/issues/311

Check List

[x] New functionality includes testing.
- [x] All tests pass
[ ] New functionality has been documented.
- [ ] New functionality has javadoc added
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hailong-am commented 4 months ago

integTest failed due to, that will need to a fix at AD side, raise PR https://github.com/opensearch-project/anomaly-detection/pull/1221

REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.integTest.SearchAnomalyDetectorsToolIT.testSearchAnomalyDetectorsToolInFlowAgent_detectorStateParams" -Dtests.seed=676D44C4FE298B5C -Dtests.security.manager=false -Dtests.locale=ar-SA -Dtests.timezone=Europe/Sofia -Druntime.java=17 {"error":{"reason":"System Error","details":"class org.opensearch.timeseries.transport.GetConfigRequest cannot be cast to class org.opensearch.timeseries.transport.GetConfigRequest (org.opensearch.timeseries.transport.GetConfigRequest is in unnamed module of loader java.net.FactoryURLClassLoader @752973de; org.opensearch.timeseries.transport.GetConfigRequest is in unnamed module of loader java.net.FactoryURLClassLoader @43c39321)","type":"ClassCastException"},"status":500}

Hailong-am commented 4 months ago

@zane-neo please help to re-run the CI, class cast exception fixed in AD and i could pass the build in my local.

opensearch-trigger-bot[bot] commented 4 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-316-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62ac87fa63a41fa460ae3795cdeaf1db927d1588
# Push it to GitHub
git push --set-upstream origin backport/backport-316-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-316-to-2.x.