opensearch-project / spring-data-opensearch

The Spring Data OpenSearch project provides Spring Data compatible integration with the OpenSearch search engine.
Apache License 2.0
118 stars 41 forks source link

Change dependency configuration of ``opensearch-rest-client-sniffer`` #329

Closed tuguri8 closed 3 months ago

tuguri8 commented 3 months ago

Description

Change dependency configuration of opensearch-rest-client-sniffer from implementation to compileOnly

Issues Resolved

resolve #323

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

tuguri8 commented 3 months ago

@reta close #328 and reopen this

reta commented 3 months ago

Thank you @tuguri8 , for some reasons DCO is failing, could you please amend the commit with --signoff and do force push:

git commit --amend --signoff
git push -f 

Thank you.

tuguri8 commented 3 months ago

Thank you @tuguri8 , for some reasons DCO is failing, could you please amend the commit with --signoff and do force push:

git commit --amend --signoff
git push -f 

Thank you.

@reta Done, thank you !