opensearch-project / sql-jdbc

This is the driver for JDBC connectivity to a cluster running with OpenSearch SQL support.
Apache License 2.0
14 stars 25 forks source link

Manifest with OSGi Metadata #124

Open stbischof opened 1 month ago

stbischof commented 1 month ago

Is your feature request related to a problem? I want to use the jdbc driver in OSGi enviroments, but cant because it has not a proper Manifest

What solution would you like? add Manifest Metadata . Minimum would be:

easiest way in build.gradle

Use the OSGi Spec complient tool bnd and let the tool generate the manifest for you

https://github.com/bndtools/bnd/blob/master/gradle-plugins/README.md


plugins {
        id 'biz.aQute.bnd.builder' version '6.4.0'
}

jar {
    bundle {
        bnd '''
            Bundle-SymbolicName: org.opensearch.jdbc
            Export-Package: org.opensearch.jdbc*
            Import-Package:  *
//maybe some marked as optional
            '''
  }
}

because of your shadow plugin i am not sure how to integrate in gradle

What alternatives have you considered?

Do you have any additional context?

Manifest-Version: 1.0
Bnd-LastModified: 1726578495191
Bundle-ManifestVersion: 2
Bundle-Name: org.opensearch.jdbc
Bundle-SymbolicName: org.opensearch.jdbc
Bundle-Version: 1.4.0.2
Created-By: 11.0.24 (Azul Systems, Inc.)
Export-Package: org.opensearch.jdbc;uses:="org.opensearch.jdbc.config,
 org.opensearch.jdbc.internal,org.opensearch.jdbc.internal.results,org
 .opensearch.jdbc.logging,org.opensearch.jdbc.protocol,org.opensearch.
 jdbc.transport";version="1.4.0",org.opensearch.jdbc.auth;version="1.4
 .0",org.opensearch.jdbc.config;uses:="org.opensearch.jdbc.auth,org.op
 ensearch.jdbc.logging";version="1.4.0",org.opensearch.jdbc.internal;v
 ersion="1.4.0",org.opensearch.jdbc.internal.exceptions;version="1.4.0
 ",org.opensearch.jdbc.internal.results;uses:="org.opensearch.jdbc.pro
 tocol,org.opensearch.jdbc.types";version="1.4.0",org.opensearch.jdbc.
 internal.util;version="1.4.0",org.opensearch.jdbc.logging;version="1.
 4.0",org.opensearch.jdbc.protocol;uses:="org.opensearch.jdbc,org.open
 search.jdbc.config,org.opensearch.jdbc.protocol.exceptions,org.opense
 arch.jdbc.transport";version="1.4.0",org.opensearch.jdbc.protocol.exc
 eptions;version="1.4.0",org.opensearch.jdbc.protocol.http;uses:="org.
 opensearch.jdbc,org.opensearch.jdbc.config,org.opensearch.jdbc.protoc
 ol,org.opensearch.jdbc.protocol.exceptions,org.opensearch.jdbc.transp
 ort,org.opensearch.jdbc.transport.http";version="1.4.0",org.opensearc
 h.jdbc.transport;uses:="org.opensearch.jdbc.config,org.opensearch.jdb
 c.logging";version="1.4.0",org.opensearch.jdbc.transport.http;uses:="
 org.opensearch.jdbc.config,org.opensearch.jdbc.logging,org.opensearch
 .jdbc.transport";version="1.4.0",org.opensearch.jdbc.transport.http.a
 uth.aws;version="1.4.0",org.opensearch.jdbc.types;version="1.4.0"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Tool: Bnd-6.4.0.202211291949
dblock commented 1 month ago

[Catch All Triage - 1, 2, 3, 4]