search

opensearch-project / sql-jdbc

This is the driver for JDBC connectivity to a cluster running with OpenSearch SQL support.
Apache License 2.0
14 stars 25 forks source link

[BUG] Release workflow is missing 2PR approval process #77

Open gaiksaya opened 1 year ago

gaiksaya commented 1 year ago

Describe the bug

Adding this issue as bug because the current 1-click process in this repository lacks this feature. See details here https://github.com/opensearch-project/opensearch-build/issues/3111 Sample PR: https://github.com/opensearch-project/opensearch-java/pull/383

To Reproduce Push a tag to this repo and release is drafted immediately. It should ask for approval before moving forward

Expected behavior The release-drafter workflow should be blocked asking for approval from 2 maintainers/codewoners to approve the release.

joshuali925 commented 1 year ago

With 1-click release process any component within opensearch organization is free to release anytime they want. All they need to do is push a tag

Not sure if i understood exactly, is it any component or any client (not a plugin)? Component onboarding mentions instructions for plugins and the 1-click release process, but i thought currently plugins cannot release anytime they want?

gaiksaya commented 1 year ago

We say component because apart from clients we have other components like data-prepper, etc. Plugins are released along with opensearch and dashboards distribution so this process does not apply to them specifically yet!